Conversation
Co-authored-by: Cliff Hansen <[email protected]>
Co-authored-by: Cliff Hansen <[email protected]>
echedey-ls
left a comment
There was a problem hiding this comment.
Nice job @kurt-rhee !! ❣️
Mainly nitpicks in documentation, I like how easy it's to read through it.
I think there is no problem in adding the test file in this @williamhobbs comment. Although, for the time being, I think it's safe to wait for PVsyst to answer @cwhanse email. @cwhanse , did you send the email/got an answer?
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
Co-authored-by: Echedey Luis <[email protected]>
|
I am not sure why pytest is failing on windows-latest 3.9 |
Ignore that one, it's failing on all branches the last day or two. |
|
PVsyst does not object to adding this capability to pvlib. They emphasize that they will not provide technical support for pvlib users. |
|
That is very nice and also reasonable of them. |
|
I compared the results of reading the two PAN files (one binary, one text) that @williamhobbs provided in #2504 and found the following potential errors:
Another thing: neither file has an IAM profile, which means a big chunk of code is not being exercised. I wonder if we could lean a bit more on @williamhobbs's goodwill to produce a file with an IAM profile? One more thing: I bet the |
|
@kandersolar, here are two more sample .pan files in a .zip. One had the option to be compatible with versions < 6.40 selected, the other without. I enabled IAM and added module dimensions, plus a few other changes. Let me know if screenshots to confirm inputs would help, or if you have other feedback/suggestions. |
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.A reader for pan files in the older binary style format